-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aws-sdk-go presigned PUT test #222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good addition! Please add a README.md in run/core/aws-sdk-go
as well.
run/core/aws-sdk-go/quick-tests.go
Outdated
// calculate the test case duration | ||
duration := time.Since(startTime) | ||
// log with the fields as per mint | ||
fields := log.Fields{"name": "minio-go", "function": function, "args": args, "duration": duration.Nanoseconds() / 1000000, "status": "pass"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log field name should be aws-sdk-go
run/core/aws-sdk-go/quick-tests.go
Outdated
var fields log.Fields | ||
// log with the fields as per mint | ||
if err != nil { | ||
fields = log.Fields{"name": "minio-go", "function": function, "args": args, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
run/core/aws-sdk-go/quick-tests.go
Outdated
fields = log.Fields{"name": "minio-go", "function": function, "args": args, | ||
"duration": duration.Nanoseconds() / 1000000, "status": "fail", "alert": alert, "message": message, "error": err} | ||
} else { | ||
fields = log.Fields{"name": "minio-go", "function": function, "args": args, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested
- Add aws-sdk-go to mint - Add presigned PUT test in aws-sdk-go - Remove presigned PUT tests in aws-sdk-php since the SDK doesn't support 'X-Amz-Content-Sha256' header with presigned requests
Ping @ebozduman |
'X-Amz-Content-Sha256' header with presigned requests
Fixes #216